fix: Use a SandboxedPersistentQueryMetadata to not interact with KafkStreams #6066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
reviewed
Aug 21, 2020
ksqldb-engine/src/main/java/io/confluent/ksql/util/QueryMetadata.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/engine/EngineContext.java
Outdated
Show resolved
Hide resolved
spena
force-pushed
the
sandbox_query_metadata
branch
from
3a1b5e3 to
8f103b7
Compare
- override only start/stop methods - add test case for not start/stop/close streams in ksqlengine sandbox
spena
force-pushed
the
sandbox_query_metadata
branch
from
8656d55 to
d5e4f73
Compare
spena
force-pushed
the
sandbox_query_metadata
branch
from
d5e4f73 to
6081eaf
Compare
sarwarbhuiyan
pushed a commit
to sarwarbhuiyan/ksql
that referenced
this pull request
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
RequestValidatorvalidates every request made to KSQL using sandboxed classes that prevents modifying real data or metadata, such as creating/deleting topics, schema, etc. Even the queries running in the system are copied to prevent they're deleted during theTERMINATEvalidation. However, the internalKafkaStreamsof the copied QueryMetadata is altered. The streams is closed which includes closing the originalKafkaStreams.This PR sandboxes the
PersistentQueryMetadatato prevent terminating theKafkaStreamsduring the request validation process.Testing done
Added unit tests.
Reviewer checklist