feat: Support IF EXISTS keyword on DROP CONNECTOR #6067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Override | ||
| public String toString() { | ||
| return "ErrorEntity{" |
There was a problem hiding this comment.
I think you mean WarningEntity here
stevenpyzhang
approved these changes
Aug 20, 2020
| return "DropConnector{" | ||
| + "connectorName='" + connectorName + '\'' | ||
| + '}'; | ||
| return toStringHelper(this) |
There was a problem hiding this comment.
Is there a reason why we're switching to using this toStringHelper function now? There seems to be a mix of using this method vs defining out manually what the string representation looks like for different AstNodes.
There was a problem hiding this comment.
Not particularly, just thought it looked neater especially now that there is more than one field.
spena
reviewed
Aug 20, 2020
| final ConnectResponse<String> response = | ||
| serviceContext.getConnectClient().delete(connectorName); | ||
|
|
||
| if (response.error().isPresent()) { | ||
| return Optional.of(new ErrorEntity(statement.getStatementText(), response.error().get())); | ||
| if (ifExists && response.httpCode() == 404) { |
There was a problem hiding this comment.
You may want to use HttpStatus.SC_NOT_FOUND instead of just 404.
spena
approved these changes
Aug 20, 2020
2 tasks
sarwarbhuiyan
pushed a commit
to sarwarbhuiyan/ksql
that referenced
this pull request
Sep 4, 2020
* feat: Support IF EXISTS keyword on DROP CONNECTOR * fix: review comments Co-authored-by: Zara Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5988
Added
IF EXISTSkeyword to theDROP CONNECTORcommand.Previously, this error message would have shown if the connector does not exist:
With this change, if the
IF EXISTSkeyword is used, the response is:If the
IF EXISTSkeyword is not used, the response is the original error response.I added a new
Entityclass calledWarningEntitythat prints a message without the Error header. It could also be used in other similar situations, such as #5992.Testing done
Added tests to
DropConnectorExecutorTest.javaReviewer checklist