-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add KSQL processing log message on uncaught streams exceptions #6253
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
ksqldb-engine/src/main/java/io/confluent/ksql/util/KafkaStreamsThreadError.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| /* | ||
| * Copyright 2020 Confluent Inc. | ||
| * | ||
| * Licensed under the Confluent Community License (the "License"); you may not use | ||
| * this file except in compliance with the License. You may obtain a copy of the | ||
| * License at | ||
| * | ||
| * http://www.confluent.io/confluent-community-license | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package io.confluent.ksql.util; | ||
|
|
||
| import static io.confluent.ksql.logging.processing.ProcessingLogMessageSchema.MessageType; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| import io.confluent.ksql.logging.processing.ProcessingLogConfig; | ||
| import io.confluent.ksql.logging.processing.ProcessingLogMessageSchema; | ||
| import io.confluent.ksql.logging.processing.ProcessingLogger; | ||
| import java.util.Objects; | ||
| import org.apache.kafka.connect.data.SchemaAndValue; | ||
| import org.apache.kafka.connect.data.Struct; | ||
|
|
||
| public final class KafkaStreamsThreadError implements ProcessingLogger.ErrorMessage { | ||
| public static KafkaStreamsThreadError of( | ||
| final String errorMsg, | ||
| final Thread thread, | ||
| final Throwable exception | ||
| ) { | ||
| return new KafkaStreamsThreadError(errorMsg, thread, exception); | ||
| } | ||
|
|
||
| private final String errorMsg; | ||
| private final Thread thread; | ||
| private final Throwable exception; | ||
|
|
||
| private KafkaStreamsThreadError( | ||
| final String errorMsg, | ||
| final Thread thread, | ||
| final Throwable exception | ||
| ) { | ||
| this.errorMsg = requireNonNull(errorMsg, "errorMsg"); | ||
| this.thread = requireNonNull(thread, "thread"); | ||
| this.exception = requireNonNull(exception, "exception"); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(final Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| final KafkaStreamsThreadError that = (KafkaStreamsThreadError) o; | ||
| return Objects.equals(errorMsg, that.errorMsg) | ||
| && Objects.equals(thread.getName(), thread.getName()) | ||
| && Objects.equals(exception.getClass(), that.exception.getClass()) | ||
| && Objects.equals(exception.toString(), that.exception.toString()); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(thread, exception); | ||
| } | ||
|
|
||
| @Override | ||
| public SchemaAndValue get(final ProcessingLogConfig config) { | ||
| final Struct struct = new Struct(ProcessingLogMessageSchema.PROCESSING_LOG_SCHEMA) | ||
| .put(ProcessingLogMessageSchema.TYPE, | ||
| MessageType.KAFKA_STREAMS_THREAD_ERROR.getTypeId()) | ||
| .put(ProcessingLogMessageSchema.KAFKA_STREAMS_THREAD_ERROR, | ||
| streamsThreadError()); | ||
|
|
||
| return new SchemaAndValue(ProcessingLogMessageSchema.PROCESSING_LOG_SCHEMA, struct); | ||
| } | ||
|
|
||
| private Struct streamsThreadError() { | ||
| final Struct threadError = new Struct(MessageType.KAFKA_STREAMS_THREAD_ERROR.getSchema()) | ||
| .put( | ||
| ProcessingLogMessageSchema.KAFKA_STREAMS_THREAD_ERROR_FIELD_NAME, | ||
| thread.getName()) | ||
| .put( | ||
| ProcessingLogMessageSchema.KAFKA_STREAMS_THREAD_ERROR_FIELD_MESSAGE, | ||
| errorMsg) | ||
| .put( | ||
| ProcessingLogMessageSchema.KAFKA_STREAMS_THREAD_ERROR_FIELD_CAUSE, | ||
| ErrorMessageUtil.getErrorMessages(exception)); | ||
|
|
||
| return threadError; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider logging this at the fatal level, since this is a thread-killing error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I log at fatal level?
The
ProcessingLoggerhas onlyerror, an theinnerlogger has onlyerror, info, debug.