-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for ALTER STREAM|TABLE #6400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jzaralim! This approach is pretty clean and straightforward. Devil is in the details, so I've added a bunch of comments around that.
ksqldb-engine/src/main/java/io/confluent/ksql/ddl/commands/DdlCommandExec.java
Outdated
Show resolved
Hide resolved
ksqldb-functional-tests/src/test/resources/query-validation-tests/alter.json
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/ddl/commands/DdlCommandExec.java
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/ddl/commands/DdlCommandExec.java
Outdated
Show resolved
Hide resolved
ksqldb-execution/src/main/java/io/confluent/ksql/execution/ddl/commands/AlterSourceCommand.java
Outdated
Show resolved
Hide resolved
ksqldb-functional-tests/src/test/resources/query-validation-tests/alter.json
Outdated
Show resolved
Hide resolved
ksqldb-rest-model/src/main/java/io/confluent/ksql/rest/entity/CommandId.java
Show resolved
Hide resolved
ksqldb-parser/src/main/java/io/confluent/ksql/parser/tree/AlterSource.java
Outdated
Show resolved
Hide resolved
I did not write a very good commit message, so here are the main changes in the most recent commit:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome work @jzaralim
Description
Add new syntax,
ALTER STREAM|TABLE
. It works as follows:It only works on data sources that are created using DDL statements.
Fixes #6038
Testing done
Unit and QTT tests.
Reviewer checklist