Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update KLIP-38 and add Docs for Variables in ksqlDB #6523

Merged
merged 4 commits into from
Oct 27, 2020
Merged

docs: update KLIP-38 and add Docs for Variables in ksqlDB #6523

merged 4 commits into from
Oct 27, 2020

Conversation

spena
Copy link
Member

@spena spena commented Oct 26, 2020

Description

Add documentation for how to use variable substitution.

Merge after #6504 is merged.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@spena spena added this to the 0.14.0 milestone Oct 26, 2020
@spena spena requested review from JimGalasyn and a team October 26, 2020 20:40
JimGalasyn
JimGalasyn approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some suggested copy edits. Great feature, thanks for the doc!

@JimGalasyn
Copy link
Member

JimGalasyn commented Oct 26, 2020 •
edited
Loading

@spena Also, should we add DEFINE to the syntax reference? If so, I'm happy to do that.

@spena spena removed the request for review from a team October 27, 2020 20:26
@spena spena merged commit a4d250e into confluentinc:master Oct 27, 2020
@spena spena deleted the docs_variable_subst branch October 27, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimGalasyn JimGalasyn JimGalasyn approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@spena @JimGalasyn