Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up leaked admin client threads when issuing join query to query-stream endpoint #6532

Merged
merged 1 commit into from
Oct 27, 2020
Merged

fix: clean up leaked admin client threads when issuing join query to query-stream endpoint #6532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions ksqldb-rest-app/src/main/java/io/confluent/ksql/rest/server/KsqlServerEndpoints.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,22 @@ public CompletableFuture<QueryPublisher> createQueryPublisher(final String sql,
final Context context,
final WorkerExecutor workerExecutor,
final ApiSecurityContext apiSecurityContext) {
return executeOnWorker(
() -> new QueryEndpoint(ksqlEngine, ksqlConfig, pullQueryExecutor, pullQueryMetrics)
.createQueryPublisher(sql, properties, context, workerExecutor,
ksqlSecurityContextProvider.provide(apiSecurityContext).getServiceContext()),
workerExecutor);
final KsqlSecurityContext ksqlSecurityContext = ksqlSecurityContextProvider
.provide(apiSecurityContext);
return executeOnWorker(() -> {
try {
return new QueryEndpoint(ksqlEngine, ksqlConfig, pullQueryExecutor, pullQueryMetrics)
.createQueryPublisher(
sql,
properties,
context,
workerExecutor,
ksqlSecurityContext.getServiceContext());
} finally {
ksqlSecurityContext.getServiceContext().close();
}
},
workerExecutor);
}

@Override
Expand Down