feat: expose support for array and struct keys #6722
Conversation
| } | ||
| for (final SimpleColumn column : columns) { | ||
| if (containsMapType(column.type())) { | ||
| throw new KsqlException("Map keys, including types that contain maps, are not supported " |
There was a problem hiding this comment.
(from a previous PR) we might want to link to #6621 in the exception of the message if anyone needs to "continue the conversation"
There was a problem hiding this comment.
Sorry, must've missed the previous comment. Updated in this PR. I went with simply See https://github.com/confluentinc/ksql/issues/6621 for more. rather than language about "continuing the conversation" since the latter makes it sound like this is an ongoing discussion which it isn't (at least as of now).
There was a problem hiding this comment.
ah sorry my comment wasn't clear! I meant (this is code from a previous PR) not (I left a comment on a previous PR). And definitely don't think we should include "continue the conversation" in the exception message! I meant it as that's what they'd be doing.
There was a problem hiding this comment.
Ah got'cha. Glad we're on the same page :)
Description
This PR adds more test coverage for array and struct keys, and exposes the feature to the world (by removing the relevant feature flag) 🎉 (partial progress towards #824)
Four commits for ease of reviewing:
Testing done
See above -- lots of new tests!
Reviewer checklist