Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: intent for klip-44: ksqlDB Go client #6825

Merged

Conversation

VanceLongwill
Copy link
Contributor

No description provided.

@VanceLongwill VanceLongwill requested a review from a team as a code owner January 4, 2021 21:55
@ghost
Copy link

ghost commented Jan 4, 2021

It looks like @VanceLongwill hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@rmoff
Copy link
Member

rmoff commented Jan 5, 2021

For consideration, https://github.com/rmoff/ksqldb-go/ does exist. However, I am new to Go and it was just an experiment in learning and probably won't pass muster :)

Once this KLIP is implemented I will happily add a note to my repo that it is deprecated in favour of a proper replacement.

@VanceLongwill
Copy link
Contributor Author

[clabot:check]

@ghost
Copy link

ghost commented Jan 5, 2021

@confluentinc It looks like @VanceLongwill just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@VanceLongwill VanceLongwill force-pushed the klip-44-intent/ksqldb-go-client branch from 792b706 to ff0874e Compare January 9, 2021 12:51
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spena
Copy link
Member

spena commented Jan 11, 2021

Thanks @VanceLongwill for the proposal. I'm looking forward to see this client implemented.

@spena spena merged commit 74fc786 into confluentinc:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants