Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce transform and reduce invocation function for lambdas #6994

Merged
merged 1 commit into from
Feb 24, 2021
Merged

feat: introduce transform and reduce invocation function for lambdas #6994

merged 1 commit into from
Feb 24, 2021

Conversation

stevenpyzhang
Copy link
Member

@stevenpyzhang stevenpyzhang commented Feb 11, 2021 •
edited
Loading

Description

Instead of needing to specify the collection type in the function name, we should just have a transform and a reduce function.

We're changing reduce so that the initial state is first and then the collection item.

There's some weirdish test results due to #7065

Testing done

Unit test and QTT's

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@stevenpyzhang stevenpyzhang force-pushed the rework-invocation-functions branch from 34faedb to a9eb41d Compare February 23, 2021 19:39
@stevenpyzhang stevenpyzhang marked this pull request as ready for review February 23, 2021 19:40
@stevenpyzhang stevenpyzhang requested a review from a team as a code owner February 23, 2021 19:40
@stevenpyzhang stevenpyzhang force-pushed the rework-invocation-functions branch 2 times, most recently from e6bc51c to 69f1450 Compare February 23, 2021 20:29
@stevenpyzhang stevenpyzhang force-pushed the rework-invocation-functions branch from 69f1450 to 7b26fd4 Compare February 24, 2021 03:22
guozhangwang
guozhangwang approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a quick pass over the non-testing part. The refactoring makes sense to me and it's good to have reduce-array too :)

@stevenpyzhang stevenpyzhang requested a review from a team February 24, 2021 05:30
@stevenpyzhang stevenpyzhang merged commit 563ff9b into confluentinc:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guozhangwang guozhangwang guozhangwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenpyzhang @guozhangwang