Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: worker-poll tasks shouldn't block main loop #7427

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

vvcephei
Copy link
Member

Description

Fixes a call to execute a task on the worker pool that still may block main event-loop
execution. See #7358 for more information.

Testing done

Just ran the tests.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vvcephei vvcephei requested review from spena and a team April 23, 2021 14:33
@vvcephei vvcephei self-assigned this Apr 23, 2021
@ghost
Copy link

ghost commented Apr 23, 2021

@confluentinc It looks like @vvcephei just signed our Contributor License Agreement. 👍

Always at your service,

clabot

Copy link
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And I also feel that we can just change it without adding more clunking tests.

@vvcephei
Copy link
Member Author

Thanks, @guozhangwang ! It looks like I need a small tweak to the matcher in the JaasProviderTest. I'll fix it and then merge once there's a green build.

@vvcephei vvcephei merged commit 0b0bf65 into master Apr 23, 2021
@vvcephei vvcephei added this to the 0.18.0 milestone Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants