fix: npe on transient query close #7530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes when queries close the closing thread times out and leaves behind the cleanup thread in streams. Then, this thread calls the state change callback which causes our metrics listener to throw an NPE. This patch changes the listener to deal with this case by checking for null values
rodesai
added a commit
to rodesai/ksql
that referenced
this pull request
May 17, 2021
Sometimes when queries close the closing thread times out and leaves behind the cleanup thread in streams. Then, this thread calls the state change callback which causes our metrics listener to throw an NPE. This patch changes the listener to deal with this case by checking for null values
rodesai
added a commit
that referenced
this pull request
May 17, 2021
Sometimes when queries close the closing thread times out and leaves behind the cleanup thread in streams. Then, this thread calls the state change callback which causes our metrics listener to throw an NPE. This patch changes the listener to deal with this case by checking for null values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes when queries close the closing thread times out and leaves behind
the cleanup thread in streams. Then, this thread calls the state change callback
which causes our metrics listener to throw an NPE. This patch changes the listener
to deal with this case by checking for null values
Reviewer checklist