Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for FK-join with format mismatch #7588

Merged
merged 1 commit into from
May 26, 2021
Merged

test: add test for FK-join with format mismatch #7588

merged 1 commit into from
May 26, 2021

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented May 26, 2021

Description

We should add a test that verifies that a format mismatch of left and right input does not trigger a repartitioning for FK-joins.

Testing done

Added QTT test.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@mjsax mjsax requested a review from a team as a code owner May 26, 2021 00:38
@mjsax mjsax mentioned this pull request May 26, 2021
Closed
mjsax
mjsax commented May 26, 2021
View reviewed changes
ksqldb-functional-tests/src/test/resources/query-validation-tests/fk-join.json
@@ -684,6 +684,60 @@
],
"post": {
"topics": {
"topics": [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updating the post condition for this test in addition.

vcrfxia
vcrfxia approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjsax -- LGTM (assuming the tests pass ;) )

@mjsax mjsax merged commit 103fac9 into confluentinc:master May 26, 2021
@mjsax mjsax deleted the minor-add-fk-test branch May 26, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjsax @vcrfxia