chore: fix alias resolution in n-way join logic #7592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vcrfxia
approved these changes
May 26, 2021
mjsax
commented
May 26, 2021
| final SourceName leftInputTableName = leftInputTable.getName(); | ||
| final List<Column> leftInputTableKeys = leftInputTable.getSchema().key(); | ||
| final DataSourceNode leftInputTable = getLeftmostSourceNode(); | ||
| final SourceName leftInputTableName = leftInputTable.getAlias(); |
There was a problem hiding this comment.
This is the actual fix: getAlias return the alias is there is one; otherwise the table name.
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to use the alias name (instead of the table name) if an alias exist to verify if the key column is present in the projection.
Testing done
Updated existing QTT tests.
Reviewer checklist