feat: define how TIME data is formatted #7674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 4, 2021 19:38
spena
reviewed
Jun 15, 2021
| import java.time.ZoneId; | ||
| import java.time.format.DateTimeFormatter; | ||
|
|
||
| /** | ||
| * Helpers for working with Sql {@code TIMESTAMP}. | ||
| * Helpers for working with SQL time types. | ||
| */ | ||
| public final class SqlTimestamps { |
There was a problem hiding this comment.
If this also work with other time types, should we rename the class to reflect that?
There was a problem hiding this comment.
Yeah. I was planning to do this in another PR, so that this one would not have so many files (this class gets referenced several times throughout the codebase)
spena
reviewed
Jun 15, 2021
Comment on lines
1152
to
1154
| @Test | ||
| public void shouldThrowOnTimeLiteral() { | ||
| // When: |
There was a problem hiding this comment.
Are there any positive tests we can have in this class?
spena
reviewed
Jun 15, 2021
Comment on lines
1061
to
1063
| @Test | ||
| public void shouldThrowOnTimeLiteral() { | ||
| // When: |
There was a problem hiding this comment.
Are there any positive tests we can have in this class?
There was a problem hiding this comment.
Did you forget to push the changes? I don't see the test added
There was a problem hiding this comment.
whoops, pushed the changes 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the TimeLiteral class and define TIME expressions to be formatted as HH:mm:ss
Testing done
Updated unit tests
Reviewer checklist