Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: define how DATE data is formatted #7700

Merged
merged 1 commit into from
Jun 18, 2021
Merged

feat: define how DATE data is formatted #7700

merged 1 commit into from
Jun 18, 2021

Conversation

jzaralim
Copy link
Contributor

Description

Adds the DateLiteral class and define DATE expressions to be formatted as yyyy-MM-dd. Also renames SqlTimestamps to SqlTimeTypes

Testing done

unit tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from spena June 18, 2021 16:27
@jzaralim jzaralim requested a review from a team as a code owner June 18, 2021 16:27
spena
spena approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzaralim jzaralim merged commit 4175ad5 into confluentinc:master Jun 18, 2021
@jzaralim jzaralim deleted the date-literal branch June 18, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzaralim @spena