Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable date/time for the query interpreter #7740

Merged
merged 1 commit into from
Jul 1, 2021
Merged

feat: enable date/time for the query interpreter #7740

merged 1 commit into from
Jul 1, 2021

Conversation

jzaralim
Copy link
Contributor

Description

Implements DATE/TIME casting and comparisons for interpreted expressions.

DATE/TIME compiled casting: #7708
DATE/TIME compiled comparisons: #7734

Testing done

Unit and manually tested

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from spena June 29, 2021 06:20
@jzaralim jzaralim requested a review from a team as a code owner June 29, 2021 06:20
spena
spena approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzaralim jzaralim merged commit 79d14fb into confluentinc:master Jul 1, 2021
@jzaralim jzaralim deleted the interp branch July 1, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzaralim @spena