feat: add BYTES type to ksqlDB #7778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzaralim
commented
Jul 9, 2021
| @Immutable | ||
| public class BytesLiteral extends Literal { | ||
|
|
||
| private final ImmutableList<Byte> value; |
There was a problem hiding this comment.
Doing this because ByteBuffer and byte[] are both mutable.
spena
reviewed
Jul 12, 2021
Comment on lines
39
to
41
| final byte[] bytes = new byte[requireNonNull(value, "value").capacity()]; | ||
| value.get(bytes); | ||
| this.value = ImmutableList.copyOf(ArrayUtils.toObject(bytes)); |
There was a problem hiding this comment.
What if you keep the final byte[] bytes at the class variable instead of the ImmutableList<Byte>? The value.get(bytes) will copy everything from ByteBuffer -> bytes, so you have an exact immutable copy.
Later, when you call getValue(), you can return ByteBuffer.wrap(bytes).asReadOnlyBuffer() to avoid the returned byte buffer can be modified.
And, when you call getByteArray(), then clone the array
return bytes == null ? null : bytes.clone();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds SqlTypes.BYTES and BytesLiteral to ksqlDB. The main KLIP, #7764, is not merged yet but this PR is almost 100% wiring with no logic, so I'm filing this now to prep for future BYTES work.
Testing done
Updated unit tests
Reviewer checklist