Skip to content

Commit

Permalink
[CI] enable timestamp in CI (dmlc#925)
Browse files Browse the repository at this point in the history
* enable timestamp in CI

* adjust notification
  • Loading branch information
szha authored Sep 18, 2019
1 parent 7995ab2 commit 6d298f5
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 12 deletions.
2 changes: 2 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here

cc @dmlc/gluon-nlp-team
2 changes: 1 addition & 1 deletion CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@


# Global owners
* @dmlc/gluon-nlp-team
* @dmlc/gluon-nlp-committers @dmlc/gluon-nlp-reviewers
27 changes: 16 additions & 11 deletions ci/jenkins/utils.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,10 @@ def main_wrapper(args) {
err = null
try {
update_github_commit_status('PENDING', 'Job has been enqueued')
args['core_logic']()

timestamps {
args['core_logic']()
}

// set build status to success at the end
currentBuild.result = "SUCCESS"
Expand All @@ -191,16 +194,18 @@ def main_wrapper(args) {
update_github_commit_status('FAILURE', 'Job failed')
}
} finally {
node {
// Call failure handler
args['failure_handler']()

// Clean workspace to reduce space requirements
cleanWs()

// Remember to rethrow so the build is marked as failing
if (err) {
throw err
timestamps {
node {
// Call failure handler
args['failure_handler']()

// Clean workspace to reduce space requirements
cleanWs()

// Remember to rethrow so the build is marked as failing
if (err) {
throw err
}
}
}
}
Expand Down

0 comments on commit 6d298f5

Please sign in to comment.