Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniplate Proof of Concept #180

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Uniplate Proof of Concept #180

merged 4 commits into from
Feb 8, 2024

Conversation

niklasdewally
Copy link
Collaborator

I whipped up some of the Uniplate functions and an example last night to show Felix - this PR puts them in this project.

A broad roadmap for this is:

  • Implement all Uniplate operations.
  • Add Zippers based on Uniplates.
  • Add Biplates.
  • Add derive macros for Uniplate, Zippers, Biplates.

Related to #177.

@niklasdewally niklasdewally self-assigned this Feb 6, 2024
@niklasdewally
Copy link
Collaborator Author

niklasdewally commented Feb 6, 2024 •
edited
Loading

Just added a fold-y thing (according to the haskell docs its a paramorphism?)

@ozgurakgun
Copy link
Contributor

Looking like a good start! I am SHOCKED to see this not being already available as a crate. Maybe we should release ours for others to use?

Let's discuss tomorrow.

@niklasdewally
Copy link
Collaborator Author

Looking like a good start! I am SHOCKED to see this not being already available as a crate. Maybe we should release ours for others to use?

Definitely! The name is free too :)

@niklasdewally niklasdewally added this to the Uniplate 1.0 milestone Feb 7, 2024
@niklasdewally niklasdewally force-pushed the nd60/uniplate branch 2 times, most recently from 87f5206 to 8edde2c Compare February 7, 2024 17:26
@ozgurakgun
Copy link
Contributor

This PR looks good to me. Do we want to merge it as is and continue working on it on separate PRs?

@niklasdewally
Copy link
Collaborator Author

This PR looks good to me. Do we want to merge it as is and continue working on it on separate PRs?

Merging now would be good :)

@niklasdewally
Copy link
Collaborator Author

niklasdewally commented Feb 8, 2024 •
edited
Loading

@ozgurakgun Will discuss more tomorrow, but I have put rough roadmaps for Uniplate and the solver interface in Github milestones.

@ozgurakgun ozgurakgun merged commit b3036d7 into conjure-cp:main Feb 8, 2024
11 checks passed
@niklasdewally niklasdewally deleted the nd60/uniplate branch February 8, 2024 17:13
@niklasdewally niklasdewally mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozgurakgun ozgurakgun Awaiting requested review from ozgurakgun

Assignees

@niklasdewally niklasdewally

Labels
None yet
Projects
None yet
Milestone
Uniplate 1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@niklasdewally @ozgurakgun