Rustsat imp #555
Rustsat imp #555
Conversation
builds, runs but untested
…solve function rmoved kissat file **currently using MiniSat
…iable Mapping, Improved solve Method(will improve more), improved model handling by updating instantiate_model_from_conjure, created a new fucntion dynamic_clause_addition, added logs and eroor handling as well
|
Hi @devansh2605 - I will review this asap, but it might take some time before I can get to it. Thanks for making the PR! |
|
In the meantime @devansh2605 are there any tests to show this running please? Ideally connected to the existing integration tester but something else, even if temporary, would be good. |
|
@ozgurakgun Yes sir, I have written 22 tests 2 of which are not working right now, will fix them today and push by end of day today. |
devansh2605
force-pushed
the
rustsat_imp
branch
from
6ec792e to
0c9a44a
Compare
|
The pull request is marked as stale because it has been inactive for 30 days. If there is no new activity it will be automatically closed in 5 days. |
|
Sir, will this be merged? |
|
Hi @devansh2605 - there are a few things we need to go over before we can merge. There is still a new sat_rs crate, which I thought we had decided not to have? Can you write a short design document explaining the approach and then we review the code? Does that sound sensible? |
Pushing my semester work by adding Incremental Solving, Optimized Variable Mapping, Improved solve Method(will improve more), improved model handling by updating instantiate_model_from_conjure, created a new function dynamic_clause_addition, added logs and error handling as well.