refactor(ast)!: refactor SymbolTable interface to hide implementation details
#614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rallel Previous to this commit, VERBOSE=true caused the tests to hang indefinitely. This commit fixes this, and makes tests without ACCEPT=true or VERBOSE=true run in parallel again. ACCEPT=true tests cannot be run in parallel as I get occasional Conjure errors when doing this (which in turn cause the tests to fail)
…on details Change the `SymbolTable` to be a struct with private members, and create a new interface to interact with it. This hides the fact that the `SymbolTable` is a `BTreeMap`. While the symbol table is a simple `BTreeMap` both before and after this commit, the implementation of this is likely to change multiple times in the future. In particular, this commit is preparation for adding `lettings` and `givens` to the symbol table.
niklasdewally
changed the title
niklasdewally
changed the title
SymbolTable interface to hide implementation details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(tester): make verbose work again, and run non-verbose tests in parallel
Previous to this commit, VERBOSE=true caused the tests to hang
indefinitely. This commit fixes this, and makes tests without
ACCEPT=true or VERBOSE=true run in parallel again. ACCEPT=true tests
cannot be run in parallel as I get occasional Conjure errors when doing
this (which in turn cause the tests to fail)
refactor(ast)!: refactor
SymbolTableinterface to hide implementation detailsChange the
SymbolTableto be a struct with private members, and createa new interface to interact with it. This hides the fact that the
SymbolTableis aBTreeMap.While the symbol table is a simple
BTreeMapboth before and after thiscommit, the implementation of this is likely to change multiple times in
the future. In particular, this commit is preparation for adding
lettingsandgivensto the symbol table.Related issues:
letting#512ReferenceToenum, with variants for lettings and decision variables #522