update uniplate to 0.2.0 #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PERFORMANCE This Uniplate update brought optimisations to `contexts` and `contexts_bi`. Using the methodology given in c4c4d7d (perf: only log rule not applicable in debug mode, 2025-01-16), and the `optimisations /implies-tautologies-cse` test case, the impact of this change is the following: Main (075c952): 790.9ms +- 11.5ms This PR: 730.2ms +- 18.7ms Savile Row -O0: 139.9ms +- 12.0ms (wall time) This is a 7.68% wall-time improvement compared to main.
As discussed in conjure-cp/uniplate#19.
ozgurakgun
approved these changes
Jan 30, 2025
|
I wonder how much of the time is spent on parsing for Oxide. Is it the via-conjure parser or the tree-sitter one you tested with? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update uniplate to v0.2.0
PERFORMANCE
This Uniplate update brought optimisations to
contextsandcontexts_bi.Using the methodology given in c4c4d7d (perf: only log rule not
applicable in debug mode, 2025-01-16), and the
optimisations /implies-tautologies-csetest case, the impact of this change is thefollowing:
Main (075c952): 790.9ms +- 11.5ms
This PR: 730.2ms +- 18.7ms
Savile Row -O0: 139.9ms +- 12.0ms
(wall time)
This is a 7.68% wall-time improvement compared to main.
tidy: use simpler
Biplatesyntax where possibleAs discussed in Nicer biplate syntax uniplate#19.