Add domain lettings #621
Merged
Add domain lettings #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasdewally
force-pushed
the
nik/implement-letting/03-domain-lettings
branch
from
ef852a1 to
41aa103
Compare
ozgurakgun
approved these changes
Jan 31, 2025
niklasdewally
force-pushed
the
nik/implement-letting/02-value-lettings
branch
from
f848945 to
7e8010a
Compare
niklasdewally
force-pushed
the
nik/implement-letting/03-domain-lettings
branch
from
41aa103 to
9444c98
Compare
Base automatically changed from
nik/implement-letting/02-value-lettings
to
main
January 31, 2025 21:09
niklasdewally
force-pushed
the
nik/implement-letting/03-domain-lettings
branch
from
9444c98 to
fc242f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for lettings of the form
letting NAME be domain DOMAINTracking issue: #512
Closes: #620
Changelog
Based on PR #619
Chain of upstream PRs as of 2025-01-31
PR Add value lettings #619:
main←nik/implement-letting/02-value-lettingsnik/implement-letting/02-value-lettings←nik/implement-letting/03-domain-lettings