Data Race: concurrent access of error state during duplexHTTPCall

[rodaine]

I'm having difficulty determining the provenance of this particular race, but adjacent to the closeSpan call alongside a send func (similar to #170):

WARNING: DATA RACE
Read at 0x00c00fc5b408 by goroutine 34631:
  connectrpc.com/connect.(*Error).Unwrap()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/error.go:210 +0x38
  errors.is()
      /Users/rodaine/pkg/mod/golang.org/[email protected]/src/errors/wrap.go:63 +0x24c
  errors.Is()
      /Users/rodaine/pkg/mod/golang.org/[email protected]/src/errors/wrap.go:50 +0xfc
  connectrpc.com/connect.IsNotModifiedError()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/error.go:264 +0x68
  connectrpc.com/otelconnect.statusCodeAttribute()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/attributes.go:110 +0x5e4
  connectrpc.com/otelconnect.(*Interceptor).WrapStreamingClient.func1.2()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/interceptor.go:234 +0x120

Previous write at 0x00c00fc5b408 by goroutine 34378:
  connectrpc.com/connect.NewError()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/error.go:133 +0xcc
  connectrpc.com/connect.wrapIfContextError()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/error.go:306 +0x114
  connectrpc.com/connect.(*duplexHTTPCall).makeRequest()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/duplex_http_call.go:310 +0x2f8
  connectrpc.com/connect.(*duplexHTTPCall).Send.gowrap1()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/duplex_http_call.go:108 +0x38

Goroutine 34631 (running) created at:
  context.(*afterFuncCtx).cancel.func1()
      /Users/rodaine/pkg/mod/golang.org/[email protected]/src/context/context.go:348 +0x44
  sync.(*Once).doSlow()
      /Users/rodaine/pkg/mod/golang.org/[email protected]/src/sync/once.go:74 +0x150
  sync.(*Once).Do()
      /Users/rodaine/pkg/mod/golang.org/[email protected]/src/sync/once.go:65 +0x58
  context.(*afterFuncCtx).cancel()
      /Users/rodaine/pkg/mod/golang.org/[email protected]/src/context/context.go:347 +0x174
  context.(*cancelCtx).cancel()
      /Users/rodaine/pkg/mod/golang.org/[email protected]/src/context/context.go:558 +0x348
  context.(*cancelCtx).cancel()
      /Users/rodaine/pkg/mod/golang.org/[email protected]/src/context/context.go:558 +0x348
  context.(*cancelCtx).cancel()
      /Users/rodaine/pkg/mod/golang.org/[email protected]/src/context/context.go:558 +0x348
  context.WithCancel.func1()
      /Users/rodaine/pkg/mod/golang.org/[email protected]/src/context/context.go:237 +0x78
  main.run.func1()
      main.go:53 +0x20c

Goroutine 34378 (finished) created at:
  connectrpc.com/connect.(*duplexHTTPCall).Send()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/duplex_http_call.go:108 +0x33c
  connectrpc.com/connect.(*envelopeWriter).write()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/envelope.go:212 +0x88
  connectrpc.com/connect.(*envelopeWriter).Write()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/envelope.go:157 +0x37c
  connectrpc.com/connect.(*envelopeWriter).marshalAppend()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/envelope.go:195 +0x564
  connectrpc.com/connect.(*envelopeWriter).Marshal()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/envelope.go:143 +0x114
  connectrpc.com/connect.(*connectStreamingClientConn).Send()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/protocol_connect.go:589 +0x54
  connectrpc.com/connect.(*errorTranslatingClientConn).Send()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/protocol.go:206 +0x7c
  connectrpc.com/otelconnect.(*streamingState).send()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/streaming.go:102 +0x68
  connectrpc.com/otelconnect.(*Interceptor).WrapStreamingClient.func1.5()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/interceptor.go:262 +0x10c
  connectrpc.com/otelconnect.(*streamingClientInterceptor).Send()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/payloadinterceptor.go:34 +0xa8
  connectrpc.com/connect.(*ClientStreamForClient[ ... ]).Send()
      /Users/rodaine/pkg/mod/connectrpc.com/[email protected]/client_stream.go:69 +0x110

[emcfarlane]

I think this is the same race as #170 . Client stream on close accesses the state of the error here:

otelconnect-go/interceptor.go

Line 234 in 0518f32

if statusCode, ok := statusCodeAttribute(protocol, state.error); ok {

Which is caused from a context cancellation that races with a receive of an error.

[jhump]

Resolved in #173, included in release v0.7.1.