parse (newline)s and pass them to tree-sitter-elixir for injection #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm thinking about this more, this does fix this particular case but I think the elixir grammar should still be more tolerant of a lack of newlines, I'll try spinning up an issue there as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok I have here what I think is a hilariously simple fix for the woes of #1 (comment) 😄. The elixir grammar can use these newlines to terminate expressions, and the eex grammar doesn't really have any use for newlines anyways.
I think this should work well with the heex/surface grammars too.
What do you think?