Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added UnsafeReadFrom for groth16 Proving and Verifying keys #160

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Oct 29, 2021

Can now decode groth16.ProvingKey and groth16.VerifyingKey without doing subgroup checks on the points.

Usage:

pk.UnsafeReadFrom(reader)

In some cases, subgroup check can be done at the application level once, and gnark user can ensure through other means (checksum, signatures, ...) that the ProvingKey / VerifyingKey are legit.

@gbotrel gbotrel added this to the v0.6.0 milestone Oct 29, 2021
@gbotrel gbotrel merged commit 71df9c6 into develop Oct 29, 2021
@gbotrel gbotrel deleted the perf-unsafe-decoding branch October 29, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant