Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sp tip email without prefixes #1559

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

trkhoi
Copy link
Contributor

@trkhoi trkhoi commented Dec 21, 2023

What does this PR do?

  • My bugfix

How to test

  • Create a detailed description of what you need to do to set this PR up. ie: Does it need migrations? Do you need to install something?
  • Create a step by step list of what the engineer needs to do to test.

Edge cases

  • What are the edge cases that you might see in this PR?

Media (Loom or gif)

  • Insert media here (if applicable)

@trkhoi trkhoi merged commit 8733b11 into develop Dec 21, 2023
@trkhoi trkhoi deleted the fix/support-tip-email-without-prefix branch December 21, 2023 02:51
trkhoi added a commit that referenced this pull request Dec 21, 2023
* develop:
  fix: sp tip email without prefixes (#1559)
jphuc96 pushed a commit that referenced this pull request Dec 21, 2023
# [6.42.0-rc.2](v6.42.0-rc.1...v6.42.0-rc.2) (2023-12-21)

### Bug Fixes

* sp tip email without prefixes ([#1559](#1559)) ([8733b11](8733b11))
trkhoi added a commit that referenced this pull request Dec 22, 2023
* preview:
  chore(release): 6.42.0-rc.5 [skip ci]
  fix: update cache ttl watchlist view (#1561)
  chore(release): 6.42.0-rc.4 [skip ci]
  fix: lock node alpine version in docker file
  chore(release): 6.42.0-rc.3 [skip ci]
  fix: validate tip email argument (#1560)
  chore(release): 6.42.0-rc.2 [skip ci]
  fix: sp tip email without prefixes (#1559)
  chore(release): 6.42.0-rc.1 [skip ci]
  feat: migrate tip email with new method (#1558)
  fix: add missing token_id field when send tip through email (#1557)
jphuc96 pushed a commit that referenced this pull request Dec 26, 2023
# [6.42.0](v6.41.3...v6.42.0) (2023-12-26)

### Bug Fixes

* add missing token_id field when send tip through email ([#1557](#1557)) ([9267b37](9267b37))
* lock node alpine version in docker file ([a5d92d2](a5d92d2))
* remove cache in watchlist ([add8781](add8781))
* sp tip email without prefixes ([#1559](#1559)) ([8733b11](8733b11))
* update cache ttl watchlist view ([#1561](#1561)) ([b14eaef](b14eaef))
* validate tip email argument ([#1560](#1560)) ([2573e94](2573e94))

### Features

* migrate tip email with new method ([#1558](#1558)) ([c0f55d5](c0f55d5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant