Clarify the meaning of max "votable" headings #4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 9, 2020
Just like we allow them on input fields.
javierm
force-pushed
the
max_headings_text
branch
2 times, most recently
from
94bd31a to
49927ae
Compare
The word "vote" is confusing because this option does not apply to the voting phase, but to the selecting projects phase.
javierm
force-pushed
the
max_headings_text
branch
from
49927ae to
602dace
Compare
taitus
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We've got two different phases where citizens can participate during a budget: the selecting projects phase, where users support projects so they can enter the voting phase, and the mentioned voting phase. We were using a text saying it affects the number of headings where users can vote, but it only affected the selecting projects phase and not the voting phase.
Objectives
Make it clear the maximum number of headings only applies to the selecting projects phase.
Visual Changes
Before these changes
After these changes