Fix footer overlap on Internet Explorer 11 #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
ie_flex
branch
2 times, most recently
from
89ba369 to
3ff1c94
Compare
There are two bugs in Internet Explorer which caused our footer to be rendered incorrectly. First, the `flex: 1` property doesn't work so well when `flex-direction` is set to `column`. We're replacing it with `flex-grow: 1`. No need to set other `flex-basis` nor `flex-shrink` in this case since in this case the default values will work just fine. Second, it didn't handle the body height being set to `100%` so well, and the footer was rendered after that 100% point, even if the content still continued. So we're using `min-height` instead, which is actually a bit more accurate (since the body is usually taller than the document root element). This causes a different issue since on IE the `flex-grow: 1` property becomes useless. This will only affect IE users with very large screens, though, and it's way better than rendering the footer overlapping the main content, so we can live with that. The page won't look as great as in other browser, but it will still be usable.
taitus
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
There are two bugs in Internet Explorer which caused our footer to be rendered incorrectly.
First, the
flex: 1property doesn't work so well whenflex-directionis set tocolumn. We're replacing it withflex-grow: 1. No need to set otherflex-basisnorflex-shrinkin this case since in this case the default values will work just fine.Second, it didn't handle the body height being set to
100%so well, and the footer was rendered after that 100% point, even if the content still continued.Objectives
Make sure the page can be read by users of all browsers
Visual changes
These screenshots were taken on Internet Explorer 11.
Before these changes
After these changes
Notes
These changes cause a different issue since now IE won't handle the
flex-grow: 1property correctly. This will only affect IE users with very large screens, though, and it's way better than rendering the footer overlapping the main content, so we can live with that. The page won't look as great as in other browser, but it will still be usable.