Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when creating admin tags #4837

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Fix bug when creating admin tags #4837

merged 1 commit into from
Jun 8, 2022

Conversation

joaoGabriel55
Copy link
Contributor

References

PR from Issue #4829

Objectives

Fix Error 422 when creating admin Tags

Visual Changes

image

@javierm javierm added the Bug label May 30, 2022
@Senen Senen self-assigned this Jun 1, 2022
Senen
Senen requested changes Jun 1, 2022
View reviewed changes
Copy link
Member

@Senen Senen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joaoGabriel55 , thanks for the PR! 🙏🏼

I left a few comments and examples in the code. Let me know what you think!

@joaoGabriel55 joaoGabriel55 force-pushed the fix_bug_when_creating_admin_tags branch from 7eca455 to 5f2dc6d Compare June 3, 2022 18:58
@javierm javierm added the 1.5 label Jun 6, 2022
@Senen
Copy link
Member

Senen commented Jun 7, 2022 •
edited
Loading

Hi @joaoGabriel55, thank you for taking the time to apply the suggestions. 🙏

As all the commits share the same objective and we are changing just two files, I think it'd be nice if you merge all the changes into a single one. You can use git rebase -i 4f1f7eaa40e2b712edc8e7cc6f8beb42a57ada13 to fix up the last three commits of four into the first one, which has the most meaningful commit message.

@joaoGabriel55
Fixed bug when creating admin tags
e767350 
Minor fix

Implemented specs for tags_controller and tag model

Code review
@joaoGabriel55 joaoGabriel55 force-pushed the fix_bug_when_creating_admin_tags branch from 5f2dc6d to e767350 Compare June 7, 2022 11:44
@javierm javierm linked an issue Jun 7, 2022 that may be closed by this pull request
Error 422 when creating admin Tags #4829
Closed
@Senen
Copy link
Member

Senen commented Jun 8, 2022

Hi @joaoGabriel55, thanks for rebasing 🙏🏼.

Just in case you are interested, at a certain point, there was a change in GitHub Actions on pull requests done by people who don't have write access to the repository. Since then, we haven't been able to run the linters in these cases. We still haven't found how to fix the issue. Sorry for that!

I just downloaded this branch and executed Pronto, and there are no issues. 👌🏼

@Senen Senen merged commit 494f1de into consuldemocracy:master Jun 8, 2022
@javierm javierm removed the 1.5 label Jun 8, 2022
@javierm javierm mentioned this pull request Jun 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Senen Senen Senen approved these changes

Assignees

@Senen Senen

@joaoGabriel55 joaoGabriel55

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error 422 when creating admin Tags
3 participants
@joaoGabriel55 @Senen @javierm