Bump rubocop from 1.18.4 to 1.35.1 #4921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
javierm
force-pushed
the
dependabot/bundler/master/rubocop-1.35.1
branch
2 times, most recently
from
a91b691 to
2452d4a
Compare
javierm
approved these changes
Aug 25, 2022
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -2,23 +2,23 @@ | |||
| Geozone.create!(name: I18n.t("seeds.geozones.north_district"), | |||
| external_code: "001", census_code: "01", | |||
| html_map_coordinates: "30,139,45,153,77,148,107,165,138,201,146,218,186,198,216,"\ | |||
| "196,233,203,240,215,283,194,329,185,377,184,388,165,369,126,333,113,334,84,320,"\ | |||
| "66,286,73,258,65,265,57,249,47,207,58,159,84,108,85,72,101,51,114") | |||
| "196,233,203,240,215,283,194,329,185,377,184,388,165,369,126,333,113,334,84,320,"\ | |||
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [122/110] (https://rubystyle.guide#max-line-length)
| "31,372,52,396,64,432,89,453,116,432,149,419,162,412,165,377,172,357,189,352,228,"\ | ||
| "327,246,313,262,297,234,291,210,284,193,284,176,294,158,303,154,310,146,289,140,"\ | ||
| "268,138,246,135,236,139,222,151,214,136,197,120,179,99,159,85,149,65,149,56,149") | ||
| "31,372,52,396,64,432,89,453,116,432,149,419,162,412,165,377,172,357,189,352,228,"\ |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [123/110] (https://rubystyle.guide#max-line-length)
| "327,246,313,262,297,234,291,210,284,193,284,176,294,158,303,154,310,146,289,140,"\ | ||
| "268,138,246,135,236,139,222,151,214,136,197,120,179,99,159,85,149,65,149,56,149") | ||
| "31,372,52,396,64,432,89,453,116,432,149,419,162,412,165,377,172,357,189,352,228,"\ | ||
| "327,246,313,262,297,234,291,210,284,193,284,176,294,158,303,154,310,146,289,140,"\ |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [123/110] (https://rubystyle.guide#max-line-length)
| "268,138,246,135,236,139,222,151,214,136,197,120,179,99,159,85,149,65,149,56,149") | ||
| "31,372,52,396,64,432,89,453,116,432,149,419,162,412,165,377,172,357,189,352,228,"\ | ||
| "327,246,313,262,297,234,291,210,284,193,284,176,294,158,303,154,310,146,289,140,"\ | ||
| "268,138,246,135,236,139,222,151,214,136,197,120,179,99,159,85,149,65,149,56,149") |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [122/110] (https://rubystyle.guide#max-line-length)
| "250,409,283,390,298,369,344,363,351,334,356,296,361,267,376,245,378,185,327,188,"\ | ||
| "281,195,239,216,245,221,245,232,261,244,281,238,300,242,304,251,285,262,278,277,"\ | ||
| "267,294,249,312,219,333,198,346,184,353") | ||
| "250,409,283,390,298,369,344,363,351,334,356,296,361,267,376,245,378,185,327,188,"\ |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [123/110] (https://rubystyle.guide#max-line-length)
| "281,195,239,216,245,221,245,232,261,244,281,238,300,242,304,251,285,262,278,277,"\ | ||
| "267,294,249,312,219,333,198,346,184,353") | ||
| "250,409,283,390,298,369,344,363,351,334,356,296,361,267,376,245,378,185,327,188,"\ | ||
| "281,195,239,216,245,221,245,232,261,244,281,238,300,242,304,251,285,262,278,277,"\ |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [123/110] (https://rubystyle.guide#max-line-length)
| Geozone.create!(name: I18n.t("seeds.geozones.central_district"), | ||
| external_code: "004", census_code: "04", | ||
| html_map_coordinates: "152,308,137,258,133,235,147,216,152,214,186,194,210,196,"\ | ||
| "228,202,240,216,241,232,263,243,293,241,301,245,302,254,286,265,274,278,267,296,"\ | ||
| "243,293,226,289,209,285,195,283,177,297") | ||
| "228,202,240,216,241,232,263,243,293,241,301,245,302,254,286,265,274,278,267,296,"\ |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [123/110] (https://rubystyle.guide#max-line-length)
javierm
force-pushed
the
dependabot/bundler/master/rubocop-1.35.1
branch
from
2452d4a to
dac4826
Compare
javierm
force-pushed
the
dependabot/bundler/master/rubocop-1.35.1
branch
from
dac4826 to
236019a
Compare
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.18.4 to 1.35.1. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.18.4...v1.35.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
This rule was added in Rubocop 1.18.0, but we didn't add it back then. Since we're applying it most of the time, we might as well be consistent and apply it everywhere.
They were added in Rubocop 1.24.0. Even if we were already applying FileRead everywhere, this is something we've manually fixed in the past. Another reason to add it is that these rules are deeply related.
This rule was added in Rubocop 1.24.0. Applying it slightly simplifies the code.
This rule was added in Rubocop 1.31.0; it follows the principles mentioned in the Ruby Style Guide [1]. https://rubystyle.guide/#atomic-file-operations
javierm
force-pushed
the
dependabot/bundler/master/rubocop-1.35.1
branch
from
236019a to
0d4a032
Compare
taitus
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 1.18.4 to 1.35.1.
Release notes
Sourced from rubocop's releases.
... (truncated)
Changelog
Sourced from rubocop's changelog.
... (truncated)
Commits
9439334Cut 1.35.1a06806dUpdate Changelog1597468[Fix #10939] Fix an error forStyle/Nexte99bc6cMerge pull request #10945 from koic/fix_an_incorrect_autocorrect_for_lint_lit...0048f70Merge pull request #10946 from fatkodima/safe-navigation-negated1c0e98dFixStyle/SafeNavigationfor negated method call with a safe navigationb69ca43[Fix #10944] Fix an incorrect autocorrect forLint/LiteralInInterpolationdc09aaeMakeInternalAffairs/SingleLineComparisonaware of negative comparison23a3924Merge pull request #10941 from fatkodima/fix-prof-slow_copsbd8a7caFixrake prof:slow_copsto return correct resultsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)