Add description to Legislation questions #4997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitus
force-pushed
the
legislation_question
branch
2 times, most recently
from
509a0de to
8f56b75
Compare
taitus
approved these changes
Feb 20, 2023
javierm
reviewed
Feb 20, 2023
db/migrate/20220924224924_add_description_to_legislation_question_translations.rb
Outdated
Show resolved
Hide resolved
taitus
force-pushed
the
legislation_question
branch
from
8f56b75 to
f1e5a73
Compare
taitus
force-pushed
the
legislation_question
branch
from
f1e5a73 to
3d7f808
Compare
taitus
force-pushed
the
legislation_question
branch
from
3d7f808 to
9235a15
Compare
javierm
force-pushed
the
legislation_question
branch
from
9235a15 to
8000277
Compare
javierm
reviewed
Feb 22, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
taitus
force-pushed
the
legislation_question
branch
from
3aac392 to
35c4bd8
Compare
taitus
force-pushed
the
legislation_question
branch
from
35c4bd8 to
30f24db
Compare
taitus
force-pushed
the
legislation_question
branch
2 times, most recently
from
5aa6033 to
b7ee935
Compare
Since we're now allowing <h2> and <h3> tags in the description, we remove the broken <h3> tag from quiz-question class. Since its content is also in the <title> element, and in order to be consistent with other show actions in the public area, we change this tag to <h1>. We add <h2> tag in the "Share" heading and we replace the broken <h4> tag above adding new styles.
taitus
force-pushed
the
legislation_question
branch
from
b7ee935 to
d96a917
Compare
javierm
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This PR resolves #4907.
Objectives
Visual Changes
Legislation question admin form (BEFORE)
Legislation question admin form (AFTER)
Legislation question admin index
Legislation question user's view