Makefile fixes, bump golang protobuf #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdef so as I understand it, this will potentially break again if something changes in |
|
We *could* lock down the dependency. There have been several attempts to do
so (read: lock down upstream dependencies, not just this one), none of
which has been officially approved. It's an ongoing issue. This PR is a
short-term band-aid.
…On Tue, May 1, 2018 at 9:23 AM, Hemant Kumar ***@***.***> wrote:
@jdef <https://github.com/jdef> so as I understand it, this will
potentially break again if something changes in protobuf/golang branch we
are tracking? Looks like - it is time we lock down protobuf/golang
dependency rather than letting it float?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#227 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACPVLM5rOiOzN4B0pyq6DYEyfBe15Z-Bks5tuGHRgaJpZM4Ttzpr>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #226
The upstream golang/protobuf project just landed, onto master, a ton of changes from their development branch and it significantly changes the generated bindings. This PR re-generates the bindings using the latest golang protoc plugin. Also included, a fix for the Makefile's so that running
make clobberworks as expected (and allows one to easily regenerate bindings locally, using the latest binaries).