Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protoc to v3.9.1, protoc-gen-go to v1.3.1 #378

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Aug 9, 2019

Dependency changes

Generation

Generated in golang:1.12.7 using:

docker run -it --volume $(pwd):/go/src/github.com/container-storage-interface/spec --workdir /go/src/github.com/container-storage-interface/spec golang:1.12.7 bash

logs: https://gist.github.com/tdmanv/7244b55e0238a38f35be1b1dfd667358

References

Fixes #377

@jieyu
Copy link
Member

jieyu commented Aug 12, 2019

This LGTM. @jdef @saad-ali can you take a look?

@saad-ali
Copy link
Member

/lgtm
/approve

@saad-ali saad-ali merged commit 3293249 into container-storage-interface:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis CI failing with undefined proto errors for trivial text change PR's
3 participants