cg2: syscall -> x/sys/unix #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to x/sys/unix definitions. I left cgroups 1 as right now it *should* be able to build on non-linux platforms, but there's a singular syscall.EINVAL check which swapping to unix would ruin. cg2 should already not be able to build on non-linux as we were using InotifyInit and Statfs_t in tests. Signed-off-by: Danny Canter <[email protected]>
AkihiroSuda
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to x/sys/unix definitions. I left cgroups 1 as right now it should be able to build on non-linux platforms, but there's a singular
syscall.EINVALcheck which swapping to unix would ruin. cg2 should already not be able to build on non-linux as we were usingInotifyInitandStatfs_tin tests.