Add Golangci-lint to CI #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
add-golangci-lint
branch
2 times, most recently
from
3cefe2f to
55e15a6
Compare
austinvazquez
force-pushed
the
add-golangci-lint
branch
3 times, most recently
from
ef1dea3 to
28147a2
Compare
|
I opted to resolve lint warnings although some of the fixes are chunky. Lmk if you have any opinions and I can address. |
AkihiroSuda
reviewed
Feb 10, 2023
Resolve warnings found by linter. Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
add-golangci-lint
branch
from
28147a2 to
7110818
Compare
estesp
approved these changes
Feb 14, 2023
AkihiroSuda
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add golangci-lint to CI
Signed-off-by: Austin Vazquez [email protected]