Remove Windows' Readlink fork #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kir Kolyshkin <[email protected]>
The next commit requires go 1.13 for Windows, so let's guard against building this package with earlier golang releases. Note that since go 1.14 is out, go 1.12 is no longer supported. Signed-off-by: Kir Kolyshkin <[email protected]>
This reverts the part of commit 8100e75 (PR containerd#113) that added the fork of Readlink() for Windows. At that time the fork was done to work around the bug in golang's implementation of os.Readlink() for Windows. The above bug was never reported upstream, but fortunately it was independently found, reported [1], and fixed [2]. The fix made its way into go-1.13 (there is no mention of that in release notes, so I checked it in git history). [1] golang/go#30463 [2] https://go-review.googlesource.com/c/go/+/164201 Signed-off-by: Kir Kolyshkin <[email protected]>
|
@cpuguy83 PTAL |
|
I like the change but I'm not sure I like that we are dropping go1.12 support so quickly. |
so when this change is disruptive, it means someone is using an unsupported golang release |
|
Understood that go1.12 is no longer a supported release from the go team, but we still use this in docker 19.03 (for now). |
|
So this one is blocked by moby/moby#40592 |
@cpuguy83 we just stopped doing it :) PTAL |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the part of commit 8100e75 (PR #113)
that added the fork of
Readlink()for Windows.At that time the fork was done to work around the bug
in golang's implementation of
os.Readlink()for Windows.The above bug was never reported upstream, but fortunately
it was independently found, reported [1], and fixed [2].
The fix made its way into go-1.13 (there is no mention of
that in release notes, so I checked it in git history).
[1] golang/go#30463
[2] https://go-review.googlesource.com/c/go/+/164201
PS since this requires go 1.13 now, add the appropriate guard
so the package won't compile on earlier golang