-
Notifications
You must be signed in to change notification settings - Fork 349
Conversation
Signed-off-by: Davanum Srinivas <[email protected]>
Hi @dims. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
does that mean tags should be used again? (there was some confusion in microsoft/hcsshim#700, also what stability/compatibility guarantees the tags provided) |
@thaJeztah yep, i believe so. the main problem was the recursive dependency which we worked through in microsoft/hcsshim#789 to split the cri-api dependencies into a separate go.mod file in the test/ directory |
Ah, thanks! oh, wow, it's vendoring itself (we were actually discussing that recently what would happen if you use vendoring in combination with a local path replace) |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good excited to be removing these dependency loops... However there is another dependency loop (logical). This dependency is one of the containerd/containerd dependencies. We typically like to move up to a new version of containerd/containerd and sync their dependency changes all at once.
Good catch; yes, so it should be updated in containerd/containerd first, and then bumped here together with containerd/containerd (and other dependencies in containerd that were updated) |
closing this. will fix containerd/containerd first |
Switch to ad tagged version of hcsshim. Context here:
kubernetes/kubernetes#87420 (comment)
Signed-off-by: Davanum Srinivas [email protected]