-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run linters on macOS and Windows as well #38
Conversation
This will fail currently (until #36 is merged; will rebase after to verify it fixes that in CI) |
70c79cb
to
fcb04e2
Compare
Arg... more compile errors on Windows;
|
d5bee1f
to
f6abba5
Compare
golangci-lint.. I hate you.. this is absolutely useless; somewhere, some place a file is detected as "not gofmt'ed".. so.. where????
|
5337989
to
f611d3f
Compare
This might be because of line endings. |
Oh! Thanks! Let me give that a try |
23fff05
to
a178792
Compare
That was it! You're a hero! It's green now (with #39 included, so still as "draft") |
Mostly to catch if we correctly specified build-tags Signed-off-by: Sebastiaan van Stijn <[email protected]>
a178792
to
a0bdb4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mostly to catch if we correctly specified build-tags (see #36)