Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go verion to 1.17 #91

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Conversation

pigletfly
Copy link
Contributor

@pigletfly pigletfly commented Apr 18, 2022

The depend in github ci workflow is already go 1.17.x

@pigletfly pigletfly force-pushed the bump-go-version branch 3 times, most recently from eba81aa to 794a43a Compare April 18, 2022 03:17
@pigletfly
Copy link
Contributor Author

and also bump actions/setup-go actions/checkout golangci/golangci-lint-action to v3.Otherwise, there is a chance to use cached go1.18 env even we pinned go version to 1.17.x

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid
Copy link
Member

fuweid commented Apr 18, 2022

@pigletfly could you use real name in commit signoff? Thanks

Signed-off-by: pigletfly <[email protected]>

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: WangBing <[email protected]>
@pigletfly
Copy link
Contributor Author

@pigletfly could you use real name in commit signoff? Thanks

Signed-off-by: pigletfly <[email protected]>

done

@fuweid fuweid merged commit 3896e7e into containerd:main Apr 19, 2022
@pigletfly pigletfly deleted the bump-go-version branch April 19, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants