Support State.Error field in inspect command #2073
Conversation
fahedouch
force-pushed
the
support-state-error
branch
2 times, most recently
from
f6ff328 to
e419819
Compare
pkg/labels/labels.go
Outdated
| @@ -90,6 +89,9 @@ const ( | |||
| // PIDContainer is the `nerdctl run --pid` for restarting | |||
| PIDContainer = Prefix + "pid-container" | |||
|
|
|||
| // RunError encapsulates a container run error. | |||
| RunError = Prefix + "run-error" | |||
There was a problem hiding this comment.
Wonder if this should be start-error or just error or errors
There was a problem hiding this comment.
start-error LGTM. error has a large scope.
There was a problem hiding this comment.
switch for error to handle stop and remove verb(s)
fahedouch
force-pushed
the
support-state-error
branch
from
1db3a1b to
3e9ea88
Compare
|
@ningziwen PTAL |
|
Thanks! @fahedouch I think this change only populates the error from If we want to make this field Docker compatible, the scope of the ErrorMsg also includes container start, stop or remove, based on the comment. The line to populate errorMsg in docker start I didn't find the line explicitly in docker stop/remove but found here is probably used to populate when container exits. Maybe we can decide if we want to populate errorMsg in the above scenarios. Based on the decision, we can change the commit message to reflect the change scope or extend the PR. |
@ningziwen PTAL |
fahedouch
force-pushed
the
support-state-error
branch
from
7a3cfe3 to
031a6fe
Compare
|
@AkihiroSuda PTAL , I added some changes |
fahedouch
force-pushed
the
support-state-error
branch
from
bcd4396 to
c0da342
Compare
Signed-off-by: fahed dorgaa <[email protected]>
fahedouch
force-pushed
the
support-state-error
branch
from
c0da342 to
512bc74
Compare
see