-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to adjust LinuxNamespaces #135
base: main
Are you sure you want to change the base?
Conversation
One line change in api.proto and regenerate the pb.go files. Signed-off-by: Etienne Champetier <[email protected]>
8e194a2
to
91fba35
Compare
91fba35
to
e4ab673
Compare
@klihub indeed ... |
Ci is broken: |
It's not CI per se IMO, rather I think some github-related PITA that hits us with regular irregularity. What happens is that every once in a while for some reason the protobuf source is cloned with a newer timestamp than the compiled bindings. When this happens our build system tries to rebuild them, but can't since we deliberately leave protoc uninstalled... because commits touching the protocol should commit both the protobuf and the generated sources. Maybe the right thing to do would be to always install protoc and the plugins we need, then always force a recompilation, and finally check that there are no changes. Why I'm reluctant to do that is that it would also implicitly/indirectly force everyone to use the same protoc{-gen-go,} versions, since those are emitted to the generated sources... Anyway, I retriggered the workflow for you, and it looks like the coin flipped the other way this time, because it succeeded. |
Currently there is a pair of PRs (#123, #124) with security implications, and it's actively being discussed what additional infra bits we'd need (mostly the ability to lock down selected adjustment capabilities in NRI administratively) so that everybody would feel confident enough about taking those changes in. Your PR is an alternative implementation of #124, so if you have valid uses cases for all of these additional capabilities, could you chime in #124 and point to this PR of yours as an alternative ? |
e4ab673
to
7088e70
Compare
Signed-off-by: Etienne Champetier <[email protected]>
79f4f24
to
808dd0b
Compare
Signed-off-by: Etienne Champetier <[email protected]>
Signed-off-by: Etienne Champetier <[email protected]>
Signed-off-by: Etienne Champetier <[email protected]>
808dd0b
to
29bb2a8
Compare
2 use cases I have in mind: