Maintain daemon mode information for each daemon instance #466
Conversation
|
need rebase 🥺 |
jiangliu
force-pushed
the
daemon-mode
branch
5 times, most recently
from
8a5c4cf to
98466c9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
+ Coverage 37.05% 37.31% +0.26%
==========================================
Files 60 59 -1
Lines 6904 6960 +56
==========================================
+ Hits 2558 2597 +39
- Misses 4046 4052 +6
- Partials 300 311 +11
|
| ID string | ||
| ProcessID int | ||
| APISocket string | ||
| LogDir string | ||
| LogLevel string | ||
| LogToStdout bool | ||
| DaemonMode config.DaemonMode |
There was a problem hiding this comment.
Do we need to handle the compatibility if the newer nydus-snapshotter is loading old records in DB without DamonMode ?
There was a problem hiding this comment.
Yes, we need to migrate the database, that's on the todo list.
There was a problem hiding this comment.
Currently it works, but may get broken in future easily. So the safe way is to convert records in databases. Rafs will face the same situation in coming PRs, so let's delay support of data migration.
There was a problem hiding this comment.
Um. I tend to tolerate the DB compatibility within this PR rather than make it a future work.
For the compatibility, I suppose it wouldn't be very complicated. Nydus-sanpshotter already has an experience on how to migrate different record formats in function tryTranslateRecords(). We can simply assign a DaemonMode by comparing daemon Mountpoint and HostRootMount and rewrite the daemon's record of state
There was a problem hiding this comment.
Added a patch to migrate the database.
Introduce daemon mode `dedicated` as an alias for `multiple`. Signed-off-by: Jiang Liu <[email protected]>
Currently the daemon mode is global and is recorded in manager, which limits extensibility. So record daemon mode in every daemon instance, so we can extend it later. Signed-off-by: Jiang Liu <[email protected]>
jiangliu
force-pushed
the
daemon-mode
branch
3 times, most recently
from
93b807e to
5c35107
Compare
Migrate boltdb from old version to add `DaemonMode` field to daemon object. Signed-off-by: Jiang Liu <[email protected]>
Why do we need to introduce the alias? |
We are planning to deprecated |
Feel like |
Currently daemon mode is a global configuration, all daemon instances must be with the same daemon mode, which limits some possible usage scenarios. So add
DaemonModeto daemon object, so daemons may have different daemon modes.Aslo add an alias for daemon mode "multiple" as "dedicated".