misc: snapshotter: Add k3s and rke2 overlays to the snapshotter daemonset
#577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fidencio
force-pushed
the
topic/misc-snapshotter-ds-add-overlays-for-other-k8s-flavours
branch
from
e259957 to
94e76e3
Compare
Let's have it under `base`, as we want to add a few overlays in order to make sure this will work as expected with kubernetes flavours such as `k3s`, or `rke2`. Signed-off-by: Fabiano Fidêncio <[email protected]>
In order to be able to override this accordingly to the kubernetes flavour being used, we want to make it slightly more flexible on our end and pass the directory instead of the file itself. Signed-off-by: Fabiano Fidêncio <[email protected]>
We're doing this in order to, later on this series, use kubectl to determine which kubernetes flavour we're running on the node. Signed-off-by: Fabiano Fidêncio <[email protected]>
fidencio
force-pushed
the
topic/misc-snapshotter-ds-add-overlays-for-other-k8s-flavours
branch
from
94e76e3 to
9517008
Compare
|
cc @ChengyuZhu6 |
imeoer
reviewed
Feb 1, 2024
Right now this is very basic and simply will let us know whether we're running on a node that's using containerd or not. This ended up with the move of parts of the logic on detecting containerd and containerd configuration files being removed from a few specific functions and being put directly into the main one. In the coming patches of this series we'll expand it to also detect other kubernetes flavours, such as `k3s` or `rke2`. Signed-off-by: Fabiano Fidêncio <[email protected]>
With these changes we're now able to also run the nydus-snapshotter daemonset on `k3s` clusters. Signed-off-by: Fabiano Fidêncio <[email protected]>
With these changes we're now able to also run the nydus-snapshotter daemonset on `rke2` clusters. Signed-off-by: Fabiano Fidêncio <[email protected]>
Differently than `k3s` or `rke2`, getting `k0s` to work as expected is quite tricky, as it relies on a drop-in configuration file, and I'm not so confident we can easily drop-in a file with all the needed bits. With this in mind, at least for now, let's just error out in case k0s is used, as at least this will make sure that the users will at least have a clue on what's been gone wrong. Signed-off-by: Fabiano Fidêncio <[email protected]>
fidencio
force-pushed
the
topic/misc-snapshotter-ds-add-overlays-for-other-k8s-flavours
branch
from
9517008 to
de19966
Compare
|
@imeoer, I'm trying to understand whether the E2E failures are related to this PR or not. |
Let's make sure the ClusterRole, ClusterRoleBinding, and the correct environment variables (such as NODE_NAME) are properly set as part of the E2E tests. Signed-off-by: ChengyuZhu6 <[email protected]> Signed-off-by: Fabiano Fidêncio <[email protected]>
fidencio
force-pushed
the
topic/misc-snapshotter-ds-add-overlays-for-other-k8s-flavours
branch
from
a54f732 to
3c70256
Compare
|
LGTM @fidencio ! |
|
@imeoer, I was able to get the full Ci green, please, let me know if anything else is needed from my side. |
ChengyuZhu6
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small series that brings support to using the nydus-snapshotter daemonset with different flavours of kubernetes.
The background of why we're doing this, is mainly because we rely on those in the Kata Containers CI.
Please, take a look at each commit message for more details.