misc: remove related images/contents/snapshots in cleanup progress #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ryansavino |
ChengyuZhu6
force-pushed
the
snapshotter-clean
branch
from
d2c7885 to
8926469
Compare
|
I fixed a few things in #605 per review comments. You may want to re-cherrypick the commits. |
ChengyuZhu6
force-pushed
the
snapshotter-clean
branch
from
8926469 to
33d2caa
Compare
Done. |
ChengyuZhu6
force-pushed
the
snapshotter-clean
branch
from
33d2caa to
31597ea
Compare
ryansavino
reviewed
Jul 30, 2024
| for i in $(nsenter -t 1 -m ctr ${ctr_args} list | grep -v KEY | cut -d' ' -f1); do | ||
| nsenter -t 1 -m ctr ${ctr_args} rm $i || true | ||
| done | ||
| remove_images |
There was a problem hiding this comment.
@ChengyuZhu6 wondering if this call to cleanup images even needs to be inside the pid check conditional statement. Why not just run it every time?
There was a problem hiding this comment.
If the snapshotter isn’t running, the remove_images function won’t have any effect.
ryansavino
approved these changes
Jul 30, 2024
|
LGTM |
remove related images/contents/snapshots in cleanup progress. Signed-off-by: ChengyuZhu6 <[email protected]>
ChengyuZhu6
force-pushed
the
snapshotter-clean
branch
from
31597ea to
27d320f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleanup process exits before completion. In addition to snapshots, we also need to clean up related content and images.
Depends on Ryan's PR #605.