Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: Remove DumpFile operations" #625

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Dec 10, 2024

This reverts commit 29243e3.

For the design of non-persistent configuration, we need to consider more factors
and cannot simply place the configuration files in the local metadata database.

This reverts commit 29243e3.

For the design of non-persistent configuration, we need to consider more factors
and cannot simply place the configuration files in the local metadata database.
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes missing coverage. Please review.

Project coverage is 21.39%. Comparing base (fcfc371) to head (9ec5a73).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pkg/filesystem/fs.go 0.00% 22 Missing ⚠️
config/daemonconfig/daemonconfig.go 0.00% 15 Missing ⚠️
pkg/daemon/daemon.go 0.00% 10 Missing ⚠️
pkg/manager/manager.go 0.00% 6 Missing ⚠️
config/daemonconfig/fscache.go 0.00% 5 Missing ⚠️
config/daemonconfig/fuse.go 0.00% 5 Missing ⚠️
pkg/manager/daemon_adaptor.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
+ Coverage   21.29%   21.39%   +0.09%     
==========================================
  Files         122      122              
  Lines       13678    13617      -61     
==========================================
  Hits         2913     2913              
+ Misses      10443    10383      -60     
+ Partials      322      321       -1     
Files with missing lines Coverage Δ
pkg/store/daemonstore.go 0.00% <ø> (ø)
pkg/store/database.go 44.16% <ø> (+7.14%) ⬆️
pkg/manager/daemon_adaptor.go 0.00% <0.00%> (ø)
config/daemonconfig/fscache.go 0.00% <0.00%> (ø)
config/daemonconfig/fuse.go 0.00% <0.00%> (ø)
pkg/manager/manager.go 0.00% <0.00%> (ø)
pkg/daemon/daemon.go 0.00% <0.00%> (ø)
config/daemonconfig/daemonconfig.go 37.77% <0.00%> (-2.70%) ⬇️
pkg/filesystem/fs.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@Desiki-high Desiki-high left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imeoer imeoer merged commit aec799e into containerd:main Dec 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants