Remove complexity from wait API #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprendes
force-pushed
the
simplify-wait
branch
26 times, most recently
from
934fdaf to
4e11501
Compare
jprendes
force-pushed
the
simplify-wait
branch
from
4e11501 to
8ad6690
Compare
jprendes
force-pushed
the
simplify-wait
branch
3 times, most recently
from
c6620e5 to
c67f641
Compare
Mossaka
reviewed
Oct 17, 2023
jsturtevant
reviewed
Oct 17, 2023
jprendes
force-pushed
the
simplify-wait
branch
2 times, most recently
from
32b4fba to
d2a0265
Compare
jprendes
force-pushed
the
simplify-wait
branch
from
d2a0265 to
9363500
Compare
Signed-off-by: Jorge Prendes <[email protected]>
jprendes
force-pushed
the
simplify-wait
branch
from
9363500 to
f4a88c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the API around the
Instance::waitmethod and aroundTaskStateandInstanceData.Fixes #339.
Note that a side effect of this PR is that it fixes #326 but it shouldn't be considered a substitute for #340.