Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry bootstrapping k3s on failure #353

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

jprendes
Copy link
Collaborator

Sporadically k3s would fail to bootstrap, see

This PR tries to mitigate this by re-bootstrapping k3s when that happens.
This change uses a timeout of 40s for k3s bootstrapping. If that fails, it uninstalls k3s, reinstalls it, and tries again.
This would continue until it succeeds or the CI timeout of 5min is hit.

Note that in the case where the kube-sys pods never show up, simply restarting the systemd service is not enough (I tired this in one of the many many attempts), which indicates that a complete reinstall is a better option.

Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👏

Thank you for digging into this issue and providing a pragmatic mitigation.

@devigned devigned requested a review from cpuguy83 October 11, 2023 11:10
@devigned devigned merged commit 62e5bc7 into containerd:main Oct 11, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants