-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fallback if git_version
fails
#355
Conversation
Signed-off-by: Jorge Prendes <[email protected]>
This is probably fine as a work around. Is there any reason to ship the source code with a simple file that includes the git commit? |
When a release is created GH creates a tar file with the source. IIUC that happens automatically. |
I was thinking something similar to https://git-scm.com/book/en/v2/Customizing-Git-Git-Attributes#_exporting_your_repository |
Hm, I was thinking of something on the line of Also that approach would not reflect any local modifications that could have been done, so it could be missleading if used for debugging. We could append a I personally prefer a |
This make sense to me based on your feedback above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Fix #341