-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make WasmtimeEngine a marker struct #782
Conversation
eecc7b7
to
a70fc6c
Compare
a70fc6c
to
0217c69
Compare
Wasmtime benchmark results are: so it seems that performance is not degraded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why do we want to make the wasmtime engine a marker struct? You've mentioned this work is a preparation for the Zygote work. Could you please elaborate?
When we introduce the zygote, we won't be able to clone the |
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
0217c69
to
f996e6f
Compare
Signed-off-by: Jorge Prendes <[email protected]>
f996e6f
to
6fe4918
Compare
This PR makes the WasmtimeEngine a marker struct which is very cheap to create.
This is in preparation for the Zygote work.